Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic#invoke (go to java) #122

Merged
merged 34 commits into from
Aug 5, 2019
Merged

generic#invoke (go to java) #122

merged 34 commits into from
Aug 5, 2019

Conversation

pantianying
Copy link
Member

What this PR does:
add generic#invoke (go to java)
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
还缺少一个filter，处理请求参数中有struct的情况。我下周会增加

Does this PR introduce a user-facing change?:

@codecov-io
Copy link

codecov-io commented Jul 4, 2019 •
edited
Loading

Codecov Report

Merging #122 into develop will increase coverage by 0.74%.
The diff coverage is 48.1%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #122      +/-   ##
===========================================
+ Coverage    67.73%   68.48%   +0.74%     
===========================================
  Files           69       71       +2     
  Lines         4383     4461      +78     
===========================================
+ Hits          2969     3055      +86     
+ Misses        1119     1106      -13     
- Partials       295      300       +5
Impacted Files Coverage Δ
config/generic_service.go 0% <0%> (ø)
config/config_loader.go 53.73% <0%> (-2.52%) ⬇️
config/reference_config.go 82.55% <25%> (-9.45%) ⬇️
filter/impl/generic_filter.go 58.33% <58.33%> (ø)
cluster/cluster_impl/base_cluster_invoker.go 48.93% <0%> (-19.15%) ⬇️
protocol/dubbo/readwriter.go 74.35% <0%> (+2.56%) ⬆️
config_center/zookeeper/listener.go 86.95% <0%> (+4.34%) ⬆️
protocol/dubbo/codec.go 82.35% <0%> (+8.82%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 092399a...0c6e36c. Read the comment docs.

fangyincheng
fangyincheng reviewed Jul 5, 2019
View reviewed changes
examples/dubbo/go-client/app/client.go Outdated Show resolved Hide resolved
examples/dubbo/go-client/app/client.go Outdated Show resolved Hide resolved
fangyincheng
fangyincheng reviewed Jul 31, 2019
View reviewed changes
config/generic_service_test.go Outdated Show resolved Hide resolved
config/reference_config.go Outdated Show resolved Hide resolved
config/reference_config.go Show resolved Hide resolved
config/reference_config.go Outdated Show resolved Hide resolved
config/reference_config.go Outdated Show resolved Hide resolved
filter/impl/generic_filter.go Outdated Show resolved Hide resolved
filter/impl/generic_filter_test.go Show resolved Hide resolved
AlexStocks
AlexStocks reviewed Aug 3, 2019
View reviewed changes
filter/impl/generic_filter.go Outdated Show resolved Hide resolved
filter/impl/generic_filter.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit 8d7c1c1 into apache:develop Aug 5, 2019
@AlexStocks AlexStocks mentioned this pull request Nov 3, 2019
Closed
LaurenceLiZhixin pushed a commit to LaurenceLiZhixin/dubbo-go that referenced this pull request Jul 17, 2021
@PhilYue
Ftr: Tengine Calls Dubbo-go Example (apache#122)
a06e170 
* Ftr: Tengine Calls Dubbo-go Example

* update: import to 3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks left review comments

@fangyincheng fangyincheng fangyincheng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pantianying @codecov-io @AlexStocks @fangyincheng